Skip to content

fix: auto-stop bumper works and refreshes #5162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Conversation

presleyp
Copy link
Contributor

Fixes #5037

The backend wasn't sending workspace updates when the auto-stop time was increased or decreased via the button on the workspace page, so I fixed that. There was a remaining issue with keeping the workspace and schedule banner in sync now that the workspace isn't getting updated all the time, so I changed the way we do that on the frontend. I looked into taking the schedule banner machine out of the workspace machine entirely, but it relies on the template so it was easier to leave it in.

@presleyp presleyp requested a review from a team as a code owner November 23, 2022 21:15
@presleyp presleyp requested review from BrunoQuaresma and removed request for a team November 23, 2022 21:15
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@presleyp presleyp merged commit d5ab4fd into main Nov 28, 2022
@presleyp presleyp deleted the schedule-inc/5037/presleyp branch November 28, 2022 15:59
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Cannot adjust auto-stop time
2 participants