fix: Fix develop script pid tracking, improve logging and interrupt #5186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
commented
Nov 29, 2022
| _ = closeFunc() | ||
| cmd.Printf("Stopped built-in PostgreSQL\n") | ||
| if err := closeFunc(); err != nil { | ||
| cmd.Printf("Failed to stop built-in PostgreSQL: %v\n", err) |
There was a problem hiding this comment.
Review: Didn't catch this issue before now because we were ignoring errors.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous refactor of the
develop.shscript had an edge case and an incorrect assumption.pg_ctlcommand started by builtin postgres during graceful shutdown, thus aborting DB shutdown whilstcoder serverexited gracefullycommand || fatal &would return the pid ofcommandwas incorrect, we were tracking the pid of the subshell (|| fatal).We now start new processes on new filedescriptors to handle the logging
> >(...)so that we can track the command pids appropriately.We also only send interrupts to the actual pids (at first).