Skip to content

fix: Close tty first in ptytest cleanup #5252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 2, 2022
Merged

fix: Close tty first in ptytest cleanup #5252

merged 4 commits into from
Dec 2, 2022

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Dec 2, 2022

This is an attempt to make ptytest closure even more robust, due to #5247.

@mafredri mafredri self-assigned this Dec 2, 2022
@mafredri mafredri requested a review from mtojek December 2, 2022 11:50
@mafredri mafredri force-pushed the mafredri/ptytest-close-improvement branch from f12df7b to 35787ec Compare December 2, 2022 11:51
mtojek
mtojek approved these changes Dec 2, 2022
View reviewed changes
@mafredri mafredri changed the title fix: Close ptytest ttys asynchronously to enable timeout fix: Close tty first in ptytest cleanup Dec 2, 2022
@mafredri mafredri force-pushed the mafredri/ptytest-close-improvement branch from ab02c23 to ba7d55a Compare December 2, 2022 12:10
@mafredri mafredri enabled auto-merge (squash) December 2, 2022 12:30
@mafredri mafredri merged commit 81c3948 into main Dec 2, 2022
@mafredri mafredri deleted the mafredri/ptytest-close-improvement branch December 2, 2022 12:32
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2022
@mafredri mafredri added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Dec 2, 2022
@mafredri mafredri added release/breaking This label is applied to PRs to detect breaking changes as part of the release process and removed release/breaking This label is applied to PRs to detect breaking changes as part of the release process labels Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @mtojek