feat: Unhide workspace rename command #5464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
Dec 19, 2022
I totally agree! It seems like a hard problem though, at least if we want to ensure that we only trigger a warning for volumes. We could maybe detect that a mutable identifier is used somewhere, but we won't know what it means. Depending on provider, it could simply be metadata which does not flag the resource for re-creation. We could of course do this for known providers, but AFAICT, it'll never be both safe and discrete (either we miss sometimes or we're very annoying) 😕. |
kylecarbs
approved these changes
Dec 19, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we've made a best-effort to protect user volumes so that we can finally unhide this command. (See #3386 for context.)
For instance,
examples/templates/dockernow uses workspace ID in the home volume name and additionally ignores all lifecycle changes, so there should be no situation where a user volume based on it (using todays template) is lost.I've expanded the warning a bit:
Thoughts?