Skip to content

fix: styles for <AlertBanner /> #5579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 4, 2023
Merged

fix: styles for <AlertBanner /> #5579

merged 3 commits into from
Jan 4, 2023

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jan 4, 2023 •
edited
Loading

This fixes a minor styling issue on the login page with the <AlertBanner />. The text alignment was centered-aligned when it should be left-aligned.

I also added some top padding to the "Click here to learn more".

I added a Storybook story to reproduce and then fixed it.

Before

image

After

image

@jsjoeio jsjoeio self-assigned this Jan 4, 2023
@jsjoeio jsjoeio marked this pull request as ready for review January 4, 2023 20:20
@jsjoeio jsjoeio requested a review from a team as a code owner January 4, 2023 20:20
@jsjoeio jsjoeio requested review from Kira-Pilot and removed request for a team January 4, 2023 20:20
@jsjoeio jsjoeio changed the title feat: add new story for LoginPageView fix: styles for <AlertBanner /> Jan 4, 2023
Kira-Pilot
Kira-Pilot approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@jsjoeio jsjoeio merged commit a231c1a into main Jan 4, 2023
@jsjoeio jsjoeio deleted the jsjoeio/fix-error-dialog branch January 4, 2023 21:46
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsjoeio @Kira-Pilot