Skip to content

feat: add storybook for /deployment/gitauth #5596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 6, 2023
Merged

feat: add storybook for /deployment/gitauth #5596

merged 6 commits into from
Jan 6, 2023

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jan 5, 2023 •
edited
Loading

  • refactor: move GitAuthSettingsPage to dir
  • refactor: split page and view GitAuthSettingsPage
  • fixup!: formatting
  • refactor: narrow props in git auth view
  • feat: add storybook for GitAuthSettingsPageView

image

@jsjoeio jsjoeio self-assigned this Jan 5, 2023
@jsjoeio jsjoeio changed the title jsjoeio/git auth storybook feat: add storybook for /deployment/gitauth Jan 5, 2023
@jsjoeio jsjoeio marked this pull request as ready for review January 5, 2023 23:19
@jsjoeio jsjoeio requested a review from a team as a code owner January 5, 2023 23:19
@jsjoeio jsjoeio requested review from presleyp and removed request for a team January 5, 2023 23:19
@jsjoeio jsjoeio marked this pull request as draft January 6, 2023 00:13
@jsjoeio jsjoeio marked this pull request as ready for review January 6, 2023 15:40
@jsjoeio jsjoeio enabled auto-merge (squash) January 6, 2023 15:40
presleyp
presleyp approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great! There's a bunch of space in the storybook, not sure if that's a storybook glitch or real.

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jan 6, 2023

There's a bunch of space in the storybook, not sure if that's a storybook glitch or real.

I didn't change any CSS so probably a glitch or just the storybook itself.

@jsjoeio jsjoeio merged commit 242676b into main Jan 6, 2023
@jsjoeio jsjoeio deleted the jsjoeio/git-auth-storybook branch January 6, 2023 16:58
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@presleyp presleyp presleyp approved these changes

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsjoeio @presleyp