docs: clarify access URL in install flow #5626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -128,7 +128,10 @@ Run Coder: | |||
| # Or just run the server directly | |||
| $ coder server | |||
|
|
|||
| Use Coder: | |||
| Default URL: http://127.0.0.1:3000 | |||
There was a problem hiding this comment.
I think the Default URL is :8080
There was a problem hiding this comment.
it is for ./scripts/develop.sh, but not when you install the binary/package
matifali
requested changes
Jan 16, 2023
|
|
||
| ```sh | ||
| # Listen on port 80 | ||
| export CODER_HTTP_ADDRESS=0.0.0.0:80 |
There was a problem hiding this comment.
Here you are using 0.0.0.0:80 but in L77 you are using 127.0.0.1:3000
This is a confusion.
ghuntley
reviewed
Jan 16, 2023
| @@ -55,7 +74,7 @@ configure the server by setting the following variables in `/etc/coder.d/coder.e | |||
| CODER_ACCESS_URL=https://coder.example.com | |||
|
|
|||
| # String. Address to serve the API and dashboard. | |||
| CODER_ADDRESS=127.0.0.1:3000 | |||
| CODER_HTTP_ADDRESS=127.0.0.1:3000 | |||
There was a problem hiding this comment.
Suggested change
| CODER_HTTP_ADDRESS=127.0.0.1:3000 | |
| CODER_HTTP_ADDRESS=0.0.0.0:3000 |
There was a problem hiding this comment.
I'm pretty sure the default is the loopback address, according to the help text.
ghuntley
reviewed
Jan 16, 2023
ghuntley
reviewed
Jan 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves #5564