fix(ci): fix winget package submission #5630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I removed the step to calculate the version, as somehow the $version was not populated with the version. Also, GitHub actions suggest removing `:set-output:` as it is deprecated. This commit should probably fix the winget package submission using `wingetcreate` cli.
bpmct
approved these changes
Jan 9, 2023
auto-merge was automatically disabled
January 9, 2023 19:31
Head branch was pushed to by a user without write access
|
@bpmct fixed a typo. It may need your approval again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the step to calculate the version, as somehow the
$versionwas not populated with the version. Also, GitHub actions suggest removing:set-output:as it is deprecated.This commit should probably fix the winget package submission using
wingetcreatecli.@bpmct Thanks for pinging me, though.
I have tested all commands locally and they seem to work.