chore: Improve bundle size #5761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
Jan 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: The main bundle
index.jswas reduced from499.45 KiBto355.74 KiBand reduced the size of the pages were using the emoji picker.I noticed Vite was showing a warning about one of the chunks getting larger than
500 KiBso I installed a plugin to start the analyses and to make it easier in the future, I added an npm script:yarn stats.The initial analyses:
What I made:
IconFieldthat was abstracting the emoji usage but we were not using it consistently, so I refactor the code to use it. After that, I created a lazy version of this component, so it could be loaded when it is needed only.testHelperswas importing therangefunction directly from the lodash bundle instead of specifying the full path.Result:
