feat(coder): add authz_querier experiment #5858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
approved these changes
Jan 25, 2023
coderd/coderdtest/coderdtest.go
Outdated
| if strings.Contains(os.Getenv("CODER_EXPERIMENTS_TEST"), "authz_querier") { | ||
| panic("Coming soon!") | ||
| if options.Authorizer != nil { | ||
| options.Authorizer = &RecordingAuthorizer{} |
There was a problem hiding this comment.
The original authorizer is needed for some routes like app execution, but we can figure that out in authzquerier branch.
Comment on lines
+2442
to
+2455
| ## codersdk.Experiment | ||
|
|
||
| ```json | ||
| "authz_querier" | ||
| ``` | ||
|
|
||
| ### Properties | ||
|
|
||
| #### Enumerated Values | ||
|
|
||
| | Value | | ||
| | --------------- | | ||
| | `authz_querier` | | ||
|
|
There was a problem hiding this comment.
This is cool. Would be cool if there was a description too. A problem for another PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it does nothing except panic when you enable it.
You shouldn't enable it unless you want coder to panic.
More stuff coming soon, promise.