Skip to content

feat: Disallow using legacy params with rich params #5974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 2, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Feb 2, 2023

Related: #5574

This PR modifies provisionerd and coderd to disallow using legacy parameters together with rich parameters. The idea is to simplify the parameter migration and deprecate legacy parameters as soon as possible.

@mtojek mtojek self-assigned this Feb 2, 2023
@mtojek mtojek requested a review from kylecarbs February 2, 2023 11:26
@mtojek mtojek marked this pull request as ready for review February 2, 2023 11:26
@mtojek mtojek mentioned this pull request Feb 2, 2023
@mtojek mtojek merged commit 271d68c into coder:main Feb 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2023
@bpmct bpmct added this to the Rich Parameters GA milestone Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants