Skip to content

chore: Allow RecordingAuthorizer to record multiple rbac authz calls #6024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 3, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Feb 3, 2023

Prior iteration only recorded the last call. This is required for
more comprehensive testing

Emyrk added 2 commits February 3, 2023 12:05
Prior iteration only recorded the last call. This is required for
more comprehensive testing
@Emyrk Emyrk requested a review from johnstcn February 3, 2023 18:30
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have tests for this now!

@Emyrk Emyrk enabled auto-merge (squash) February 3, 2023 18:59
@Emyrk Emyrk merged commit b359dbb into main Feb 3, 2023
@Emyrk Emyrk deleted the stevenmasley/recording_authorizer_update branch February 3, 2023 19:03
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants