diff --git a/cli/create_test.go b/cli/create_test.go index ac607617f1bf1..b4cf3c2f63258 100644 --- a/cli/create_test.go +++ b/cli/create_test.go @@ -87,7 +87,7 @@ func TestCreate(t *testing.T) { _ = coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID) cmd, root := clitest.New(t, "create", "my-workspace", "-y") - member := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) + member, _ := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) clitest.SetupConfig(t, member, root) cmdCtx, done := context.WithTimeout(context.Background(), testutil.WaitLong) go func() { diff --git a/cli/delete_test.go b/cli/delete_test.go index 499c90ef31234..24a4975d911db 100644 --- a/cli/delete_test.go +++ b/cli/delete_test.go @@ -77,7 +77,7 @@ func TestDelete(t *testing.T) { adminClient := coderdtest.New(t, &coderdtest.Options{IncludeProvisionerDaemon: true}) adminUser := coderdtest.CreateFirstUser(t, adminClient) orgID := adminUser.OrganizationID - client := coderdtest.CreateAnotherUser(t, adminClient, orgID) + client, _ := coderdtest.CreateAnotherUser(t, adminClient, orgID) user, err := client.User(context.Background(), codersdk.Me) require.NoError(t, err) diff --git a/cli/userlist_test.go b/cli/userlist_test.go index 35ba24aeec064..36cf17b188ac3 100644 --- a/cli/userlist_test.go +++ b/cli/userlist_test.go @@ -87,12 +87,9 @@ func TestUserShow(t *testing.T) { t.Run("Table", func(t *testing.T) { t.Parallel() - ctx := context.Background() client := coderdtest.New(t, nil) admin := coderdtest.CreateFirstUser(t, client) - other := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID) - otherUser, err := other.User(ctx, codersdk.Me) - require.NoError(t, err, "fetch other user") + _, otherUser := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID) cmd, root := clitest.New(t, "users", "show", otherUser.Username) clitest.SetupConfig(t, client, root) doneChan := make(chan struct{}) @@ -114,7 +111,7 @@ func TestUserShow(t *testing.T) { ctx := context.Background() client := coderdtest.New(t, nil) admin := coderdtest.CreateFirstUser(t, client) - other := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID) + other, _ := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID) otherUser, err := other.User(ctx, codersdk.Me) require.NoError(t, err, "fetch other user") cmd, root := clitest.New(t, "users", "show", otherUser.Username, "-o", "json") diff --git a/cli/userstatus_test.go b/cli/userstatus_test.go index 05fe8898c82e6..430fa501a6ee0 100644 --- a/cli/userstatus_test.go +++ b/cli/userstatus_test.go @@ -17,7 +17,7 @@ func TestUserStatus(t *testing.T) { t.Parallel() client := coderdtest.New(t, nil) admin := coderdtest.CreateFirstUser(t, client) - other := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID) + other, _ := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID) otherUser, err := other.User(context.Background(), codersdk.Me) require.NoError(t, err, "fetch user") diff --git a/coderd/apikey_test.go b/coderd/apikey_test.go index 9361ced76e7bf..2cc0596fb3e13 100644 --- a/coderd/apikey_test.go +++ b/coderd/apikey_test.go @@ -137,7 +137,7 @@ func TestSessionExpiry(t *testing.T) { // this test it works because we don't copy the value (and we use pointers). dc.SessionDuration.Value = time.Second - userClient := coderdtest.CreateAnotherUser(t, adminClient, adminUser.OrganizationID) + userClient, _ := coderdtest.CreateAnotherUser(t, adminClient, adminUser.OrganizationID) // Find the session cookie, and ensure it has the correct expiry. token := userClient.SessionToken() diff --git a/coderd/authorize_test.go b/coderd/authorize_test.go index 811ade7048623..f19cd361ca70f 100644 --- a/coderd/authorize_test.go +++ b/coderd/authorize_test.go @@ -24,10 +24,10 @@ func TestCheckPermissions(t *testing.T) { }) // Create adminClient, member, and org adminClient adminUser := coderdtest.CreateFirstUser(t, adminClient) - memberClient := coderdtest.CreateAnotherUser(t, adminClient, adminUser.OrganizationID) + memberClient, _ := coderdtest.CreateAnotherUser(t, adminClient, adminUser.OrganizationID) memberUser, err := memberClient.User(ctx, codersdk.Me) require.NoError(t, err) - orgAdminClient := coderdtest.CreateAnotherUser(t, adminClient, adminUser.OrganizationID, rbac.RoleOrgAdmin(adminUser.OrganizationID)) + orgAdminClient, _ := coderdtest.CreateAnotherUser(t, adminClient, adminUser.OrganizationID, rbac.RoleOrgAdmin(adminUser.OrganizationID)) orgAdminUser, err := orgAdminClient.User(ctx, codersdk.Me) require.NoError(t, err) diff --git a/coderd/coderdtest/coderdtest.go b/coderd/coderdtest/coderdtest.go index 0999355c1034d..93a4dbeba966f 100644 --- a/coderd/coderdtest/coderdtest.go +++ b/coderd/coderdtest/coderdtest.go @@ -447,12 +447,7 @@ func CreateFirstUser(t *testing.T, client *codersdk.Client) codersdk.CreateFirst } // CreateAnotherUser creates and authenticates a new user. -func CreateAnotherUser(t *testing.T, client *codersdk.Client, organizationID uuid.UUID, roles ...string) *codersdk.Client { - userClient, _ := createAnotherUserRetry(t, client, organizationID, 5, roles...) - return userClient -} - -func CreateAnotherUserWithUser(t *testing.T, client *codersdk.Client, organizationID uuid.UUID, roles ...string) (*codersdk.Client, codersdk.User) { +func CreateAnotherUser(t *testing.T, client *codersdk.Client, organizationID uuid.UUID, roles ...string) (*codersdk.Client, codersdk.User) { return createAnotherUserRetry(t, client, organizationID, 5, roles...) } diff --git a/coderd/organizations_test.go b/coderd/organizations_test.go index a23d7921305c2..87d69fc508c61 100644 --- a/coderd/organizations_test.go +++ b/coderd/organizations_test.go @@ -46,7 +46,7 @@ func TestOrganizationByUserAndName(t *testing.T) { t.Parallel() client := coderdtest.New(t, nil) first := coderdtest.CreateFirstUser(t, client) - other := coderdtest.CreateAnotherUser(t, client, first.OrganizationID) + other, _ := coderdtest.CreateAnotherUser(t, client, first.OrganizationID) ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong) defer cancel() diff --git a/coderd/roles_test.go b/coderd/roles_test.go index 99496bec963f1..5e5bad8c455ef 100644 --- a/coderd/roles_test.go +++ b/coderd/roles_test.go @@ -19,8 +19,8 @@ func TestListRoles(t *testing.T) { client := coderdtest.New(t, nil) // Create admin, member, and org admin admin := coderdtest.CreateFirstUser(t, client) - member := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID) - orgAdmin := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID, rbac.RoleOrgAdmin(admin.OrganizationID)) + member, _ := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID) + orgAdmin, _ := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID, rbac.RoleOrgAdmin(admin.OrganizationID)) ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong) t.Cleanup(cancel) diff --git a/coderd/templateversions_test.go b/coderd/templateversions_test.go index b3afbf1f14b3c..9bf43e95438a4 100644 --- a/coderd/templateversions_test.go +++ b/coderd/templateversions_test.go @@ -47,7 +47,7 @@ func TestTemplateVersion(t *testing.T) { ctx, _ := testutil.Context(t) - client1, _ := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + client1, _ := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) _, err := client1.TemplateVersion(ctx, version.ID) require.NoError(t, err) diff --git a/coderd/users_test.go b/coderd/users_test.go index b07102b420e38..ec24f6e667281 100644 --- a/coderd/users_test.go +++ b/coderd/users_test.go @@ -149,7 +149,7 @@ func TestPostLogin(t *testing.T) { numLogs++ // add an audit log for create user numLogs++ // add an audit log for login - member := coderdtest.CreateAnotherUser(t, client, first.OrganizationID) + member, _ := coderdtest.CreateAnotherUser(t, client, first.OrganizationID) numLogs++ // add an audit log for create user ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong) @@ -302,7 +302,7 @@ func TestDeleteUser(t *testing.T) { t.Parallel() api := coderdtest.New(t, nil) user := coderdtest.CreateFirstUser(t, api) - _, another := coderdtest.CreateAnotherUserWithUser(t, api, user.OrganizationID) + _, another := coderdtest.CreateAnotherUser(t, api, user.OrganizationID) err := api.DeleteUser(context.Background(), another.ID) require.NoError(t, err) // Attempt to create a user with the same email and username, and delete them again. @@ -320,7 +320,7 @@ func TestDeleteUser(t *testing.T) { t.Parallel() api := coderdtest.New(t, nil) firstUser := coderdtest.CreateFirstUser(t, api) - client, _ := coderdtest.CreateAnotherUserWithUser(t, api, firstUser.OrganizationID) + client, _ := coderdtest.CreateAnotherUser(t, api, firstUser.OrganizationID) err := client.DeleteUser(context.Background(), firstUser.UserID) var apiErr *codersdk.Error require.ErrorAs(t, err, &apiErr) @@ -330,7 +330,7 @@ func TestDeleteUser(t *testing.T) { t.Parallel() client, _ := coderdtest.NewWithProvisionerCloser(t, nil) user := coderdtest.CreateFirstUser(t, client) - anotherClient, another := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + anotherClient, another := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil) coderdtest.AwaitTemplateVersionJob(t, client, version.ID) template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID) @@ -452,8 +452,8 @@ func TestPostUsers(t *testing.T) { t.Parallel() client := coderdtest.New(t, nil) first := coderdtest.CreateFirstUser(t, client) - notInOrg := coderdtest.CreateAnotherUser(t, client, first.OrganizationID) - other := coderdtest.CreateAnotherUser(t, client, first.OrganizationID, rbac.RoleOwner(), rbac.RoleMember()) + notInOrg, _ := coderdtest.CreateAnotherUser(t, client, first.OrganizationID) + other, _ := coderdtest.CreateAnotherUser(t, client, first.OrganizationID, rbac.RoleOwner(), rbac.RoleMember()) ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong) defer cancel() @@ -511,7 +511,7 @@ func TestPostUsers(t *testing.T) { firstUser, err := client.User(ctx, firstUserResp.UserID.String()) require.NoError(t, err) - _ = coderdtest.CreateAnotherUser(t, client, firstUserResp.OrganizationID) + _, _ = coderdtest.CreateAnotherUser(t, client, firstUserResp.OrganizationID) allUsersRes, err := client.Users(ctx, codersdk.UsersRequest{}) require.NoError(t, err) @@ -605,7 +605,7 @@ func TestUpdateUserPassword(t *testing.T) { t.Parallel() client := coderdtest.New(t, nil) admin := coderdtest.CreateFirstUser(t, client) - member := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID) + member, _ := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID) ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong) defer cancel() @@ -652,7 +652,7 @@ func TestUpdateUserPassword(t *testing.T) { numLogs++ // add an audit log for user create numLogs++ // add an audit log for login - member := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID) + member, _ := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID) numLogs++ // add an audit log for user create ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong) @@ -673,7 +673,7 @@ func TestUpdateUserPassword(t *testing.T) { t.Parallel() client := coderdtest.New(t, nil) admin := coderdtest.CreateFirstUser(t, client) - member := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID) + member, _ := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID) ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong) defer cancel() @@ -784,14 +784,14 @@ func TestGrantSiteRoles(t *testing.T) { admin := coderdtest.New(t, nil) first := coderdtest.CreateFirstUser(t, admin) - member := coderdtest.CreateAnotherUser(t, admin, first.OrganizationID) - orgAdmin := coderdtest.CreateAnotherUser(t, admin, first.OrganizationID, rbac.RoleOrgAdmin(first.OrganizationID)) + member, _ := coderdtest.CreateAnotherUser(t, admin, first.OrganizationID) + orgAdmin, _ := coderdtest.CreateAnotherUser(t, admin, first.OrganizationID, rbac.RoleOrgAdmin(first.OrganizationID)) randOrg, err := admin.CreateOrganization(ctx, codersdk.CreateOrganizationRequest{ Name: "random", }) require.NoError(t, err) - _, randOrgUser := coderdtest.CreateAnotherUserWithUser(t, admin, randOrg.ID, rbac.RoleOrgAdmin(randOrg.ID)) - userAdmin := coderdtest.CreateAnotherUser(t, admin, first.OrganizationID, rbac.RoleUserAdmin()) + _, randOrgUser := coderdtest.CreateAnotherUser(t, admin, randOrg.ID, rbac.RoleOrgAdmin(randOrg.ID)) + userAdmin, _ := coderdtest.CreateAnotherUser(t, admin, first.OrganizationID, rbac.RoleUserAdmin()) const newUser = "newUser" @@ -901,7 +901,7 @@ func TestGrantSiteRoles(t *testing.T) { if c.OrgID != uuid.Nil { orgID = c.OrgID } - _, newUser := coderdtest.CreateAnotherUserWithUser(t, admin, orgID) + _, newUser := coderdtest.CreateAnotherUser(t, admin, orgID) c.AssignToUser = newUser.ID.String() } @@ -962,7 +962,7 @@ func TestPutUserSuspend(t *testing.T) { t.Parallel() client := coderdtest.New(t, nil) me := coderdtest.CreateFirstUser(t, client) - _, user := coderdtest.CreateAnotherUserWithUser(t, client, me.OrganizationID, rbac.RoleOwner()) + _, user := coderdtest.CreateAnotherUser(t, client, me.OrganizationID, rbac.RoleOwner()) ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong) defer cancel() @@ -981,7 +981,7 @@ func TestPutUserSuspend(t *testing.T) { numLogs++ // add an audit log for user create numLogs++ // add an audit log for login - _, user := coderdtest.CreateAnotherUserWithUser(t, client, me.OrganizationID) + _, user := coderdtest.CreateAnotherUser(t, client, me.OrganizationID) numLogs++ // add an audit log for user create ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong) @@ -1085,7 +1085,7 @@ func TestUsersFilter(t *testing.T) { if i%3 == 0 { roles = append(roles, "auditor") } - userClient := coderdtest.CreateAnotherUser(t, client, first.OrganizationID, roles...) + userClient, _ := coderdtest.CreateAnotherUser(t, client, first.OrganizationID, roles...) user, err := userClient.User(ctx, codersdk.Me) require.NoError(t, err, "fetch me") diff --git a/coderd/workspaceapps_test.go b/coderd/workspaceapps_test.go index cd254748ea5b2..9a30c79da19dc 100644 --- a/coderd/workspaceapps_test.go +++ b/coderd/workspaceapps_test.go @@ -337,7 +337,7 @@ func TestWorkspaceAppsProxyPath(t *testing.T) { t.Run("NoAccessShould404", func(t *testing.T) { t.Parallel() - userClient := coderdtest.CreateAnotherUser(t, client, firstUser.OrganizationID, rbac.RoleMember()) + userClient, _ := coderdtest.CreateAnotherUser(t, client, firstUser.OrganizationID, rbac.RoleMember()) userClient.HTTPClient.CheckRedirect = client.HTTPClient.CheckRedirect userClient.HTTPClient.Transport = client.HTTPClient.Transport @@ -765,7 +765,7 @@ func TestWorkspaceAppsProxySubdomain(t *testing.T) { t.Run("NoAccessShould401", func(t *testing.T) { t.Parallel() - userClient := coderdtest.CreateAnotherUser(t, client, firstUser.OrganizationID, rbac.RoleMember()) + userClient, _ := coderdtest.CreateAnotherUser(t, client, firstUser.OrganizationID, rbac.RoleMember()) userClient.HTTPClient.CheckRedirect = client.HTTPClient.CheckRedirect userClient.HTTPClient.Transport = client.HTTPClient.Transport diff --git a/coderd/workspacebuilds_test.go b/coderd/workspacebuilds_test.go index f1c103be6ff0d..78955796388e1 100644 --- a/coderd/workspacebuilds_test.go +++ b/coderd/workspacebuilds_test.go @@ -185,13 +185,11 @@ func TestWorkspaceBuilds(t *testing.T) { t.Parallel() client := coderdtest.New(t, &coderdtest.Options{IncludeProvisionerDaemon: true}) first := coderdtest.CreateFirstUser(t, client) - second := coderdtest.CreateAnotherUser(t, client, first.OrganizationID, "owner") + second, secondUser := coderdtest.CreateAnotherUser(t, client, first.OrganizationID, "owner") ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong) defer cancel() - secondUser, err := second.User(ctx, codersdk.Me) - require.NoError(t, err, "fetch me") version := coderdtest.CreateTemplateVersion(t, client, first.OrganizationID, nil) template := coderdtest.CreateTemplate(t, client, first.OrganizationID, version.ID) coderdtest.AwaitTemplateVersionJob(t, client, version.ID) @@ -307,7 +305,7 @@ func TestWorkspaceBuildsProvisionerState(t *testing.T) { // A regular user on the very same template must not be able to modify the // state. - regularUser := coderdtest.CreateAnotherUser(t, client, first.OrganizationID) + regularUser, _ := coderdtest.CreateAnotherUser(t, client, first.OrganizationID) workspace = coderdtest.CreateWorkspace(t, regularUser, first.OrganizationID, template.ID) coderdtest.AwaitWorkspaceBuildJob(t, regularUser, workspace.LatestBuild.ID) @@ -425,7 +423,7 @@ func TestPatchCancelWorkspaceBuild(t *testing.T) { coderdtest.AwaitTemplateVersionJob(t, client, version.ID) template := coderdtest.CreateTemplate(t, client, owner.OrganizationID, version.ID) - userClient := coderdtest.CreateAnotherUser(t, client, owner.OrganizationID) + userClient, _ := coderdtest.CreateAnotherUser(t, client, owner.OrganizationID) workspace := coderdtest.CreateWorkspace(t, userClient, owner.OrganizationID, template.ID) var build codersdk.WorkspaceBuild diff --git a/coderd/workspaces_test.go b/coderd/workspaces_test.go index 54161c5fcce08..cc7b8e0e3467a 100644 --- a/coderd/workspaces_test.go +++ b/coderd/workspaces_test.go @@ -175,7 +175,7 @@ func TestAdminViewAllWorkspaces(t *testing.T) { // This other user is not in the first user's org. Since other is an admin, they can // still see the "first" user's workspace. - otherOwner := coderdtest.CreateAnotherUser(t, client, otherOrg.ID, rbac.RoleOwner()) + otherOwner, _ := coderdtest.CreateAnotherUser(t, client, otherOrg.ID, rbac.RoleOwner()) otherWorkspaces, err := otherOwner.Workspaces(ctx, codersdk.WorkspaceFilter{}) require.NoError(t, err, "(other) fetch workspaces") @@ -185,7 +185,7 @@ func TestAdminViewAllWorkspaces(t *testing.T) { require.ElementsMatch(t, otherWorkspaces.Workspaces, firstWorkspaces.Workspaces) require.Equal(t, len(firstWorkspaces.Workspaces), 1, "should be 1 workspace present") - memberView := coderdtest.CreateAnotherUser(t, client, otherOrg.ID) + memberView, _ := coderdtest.CreateAnotherUser(t, client, otherOrg.ID) memberViewWorkspaces, err := memberView.Workspaces(ctx, codersdk.WorkspaceFilter{}) require.NoError(t, err, "(member) fetch workspaces") require.Equal(t, 0, len(memberViewWorkspaces.Workspaces), "member in other org should see 0 workspaces") @@ -216,7 +216,7 @@ func TestPostWorkspacesByOrganization(t *testing.T) { client := coderdtest.New(t, nil) first := coderdtest.CreateFirstUser(t, client) - other := coderdtest.CreateAnotherUser(t, client, first.OrganizationID, rbac.RoleMember(), rbac.RoleOwner()) + other, _ := coderdtest.CreateAnotherUser(t, client, first.OrganizationID, rbac.RoleMember(), rbac.RoleOwner()) ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong) defer cancel() @@ -510,11 +510,10 @@ func TestWorkspaceFilter(t *testing.T) { users := make([]coderUser, 0) for i := 0; i < 10; i++ { - userClient := coderdtest.CreateAnotherUser(t, client, first.OrganizationID, rbac.RoleOwner()) - user, err := userClient.User(ctx, codersdk.Me) - require.NoError(t, err, "fetch me") + userClient, user := coderdtest.CreateAnotherUser(t, client, first.OrganizationID, rbac.RoleOwner()) if i%3 == 0 { + var err error user, err = client.UpdateUserProfile(ctx, user.ID.String(), codersdk.UpdateUserProfileRequest{ Username: strings.ToUpper(user.Username), }) diff --git a/enterprise/cli/groupedit_test.go b/enterprise/cli/groupedit_test.go index f8581e607f68f..17342e4494b44 100644 --- a/enterprise/cli/groupedit_test.go +++ b/enterprise/cli/groupedit_test.go @@ -33,9 +33,9 @@ func TestGroupEdit(t *testing.T) { }) ctx, _ := testutil.Context(t) - _, user1 := coderdtest.CreateAnotherUserWithUser(t, client, admin.OrganizationID) - _, user2 := coderdtest.CreateAnotherUserWithUser(t, client, admin.OrganizationID) - _, user3 := coderdtest.CreateAnotherUserWithUser(t, client, admin.OrganizationID) + _, user1 := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID) + _, user2 := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID) + _, user3 := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID) group, err := client.CreateGroup(ctx, admin.OrganizationID, codersdk.CreateGroupRequest{ Name: "alpha", diff --git a/enterprise/cli/grouplist_test.go b/enterprise/cli/grouplist_test.go index e806e1e52517e..1132925bb66ee 100644 --- a/enterprise/cli/grouplist_test.go +++ b/enterprise/cli/grouplist_test.go @@ -31,8 +31,8 @@ func TestGroupList(t *testing.T) { }) ctx, _ := testutil.Context(t) - _, user1 := coderdtest.CreateAnotherUserWithUser(t, client, admin.OrganizationID) - _, user2 := coderdtest.CreateAnotherUserWithUser(t, client, admin.OrganizationID) + _, user1 := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID) + _, user2 := coderdtest.CreateAnotherUser(t, client, admin.OrganizationID) // We intentionally create the first group as beta so that we // can assert that things are being sorted by name intentionally diff --git a/enterprise/coderd/appearance_test.go b/enterprise/coderd/appearance_test.go index 6b1c000bec91b..a1192c784aa4d 100644 --- a/enterprise/coderd/appearance_test.go +++ b/enterprise/coderd/appearance_test.go @@ -41,7 +41,7 @@ func TestServiceBanners(t *testing.T) { require.NoError(t, err) require.False(t, sb.ServiceBanner.Enabled) - basicUserClient := coderdtest.CreateAnotherUser(t, adminClient, adminUser.OrganizationID) + basicUserClient, _ := coderdtest.CreateAnotherUser(t, adminClient, adminUser.OrganizationID) // Regular user should be unable to set the banner sb.ServiceBanner.Enabled = true diff --git a/enterprise/coderd/authorize_test.go b/enterprise/coderd/authorize_test.go index c15c4e46835ab..5a39675721993 100644 --- a/enterprise/coderd/authorize_test.go +++ b/enterprise/coderd/authorize_test.go @@ -34,10 +34,10 @@ func TestCheckACLPermissions(t *testing.T) { }, }) - memberClient := coderdtest.CreateAnotherUser(t, adminClient, adminUser.OrganizationID) + memberClient, _ := coderdtest.CreateAnotherUser(t, adminClient, adminUser.OrganizationID) memberUser, err := memberClient.User(ctx, codersdk.Me) require.NoError(t, err) - orgAdminClient := coderdtest.CreateAnotherUser(t, adminClient, adminUser.OrganizationID, rbac.RoleOrgAdmin(adminUser.OrganizationID)) + orgAdminClient, _ := coderdtest.CreateAnotherUser(t, adminClient, adminUser.OrganizationID, rbac.RoleOrgAdmin(adminUser.OrganizationID)) orgAdminUser, err := orgAdminClient.User(ctx, codersdk.Me) require.NoError(t, err) diff --git a/enterprise/coderd/groups_test.go b/enterprise/coderd/groups_test.go index a6081f1a5a478..45c2243e1afe1 100644 --- a/enterprise/coderd/groups_test.go +++ b/enterprise/coderd/groups_test.go @@ -196,8 +196,8 @@ func TestPatchGroup(t *testing.T) { codersdk.FeatureTemplateRBAC: 1, }, }) - _, user2 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) - _, user3 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + _, user2 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) + _, user3 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) ctx, _ := testutil.Context(t) group, err := client.CreateGroup(ctx, user.OrganizationID, codersdk.CreateGroupRequest{ @@ -224,9 +224,9 @@ func TestPatchGroup(t *testing.T) { codersdk.FeatureTemplateRBAC: 1, }, }) - _, user2 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) - _, user3 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) - _, user4 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + _, user2 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) + _, user3 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) + _, user4 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) ctx, _ := testutil.Context(t) group, err := client.CreateGroup(ctx, user.OrganizationID, codersdk.CreateGroupRequest{ @@ -385,7 +385,7 @@ func TestPatchGroup(t *testing.T) { codersdk.FeatureTemplateRBAC: 1, }, }) - _, user2 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + _, user2 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) ctx, _ := testutil.Context(t) group, err := client.CreateGroup(ctx, user.OrganizationID, codersdk.CreateGroupRequest{ Name: "hi", @@ -488,8 +488,8 @@ func TestGroup(t *testing.T) { codersdk.FeatureTemplateRBAC: 1, }, }) - _, user2 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) - _, user3 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + _, user2 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) + _, user3 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) ctx, _ := testutil.Context(t) group, err := client.CreateGroup(ctx, user.OrganizationID, codersdk.CreateGroupRequest{ @@ -520,7 +520,7 @@ func TestGroup(t *testing.T) { codersdk.FeatureTemplateRBAC: 1, }, }) - client1, _ := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + client1, _ := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) ctx, _ := testutil.Context(t) group, err := client.CreateGroup(ctx, user.OrganizationID, codersdk.CreateGroupRequest{ @@ -544,8 +544,8 @@ func TestGroup(t *testing.T) { }, }) - _, user1 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) - _, user2 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + _, user1 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) + _, user2 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) ctx, _ := testutil.Context(t) group, err := client.CreateGroup(ctx, user.OrganizationID, codersdk.CreateGroupRequest{ @@ -579,8 +579,8 @@ func TestGroup(t *testing.T) { }, }) - _, user1 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) - _, user2 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + _, user1 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) + _, user2 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) ctx, _ := testutil.Context(t) group, err := client.CreateGroup(ctx, user.OrganizationID, codersdk.CreateGroupRequest{ @@ -641,10 +641,10 @@ func TestGroups(t *testing.T) { codersdk.FeatureTemplateRBAC: 1, }, }) - _, user2 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) - _, user3 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) - _, user4 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) - _, user5 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + _, user2 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) + _, user3 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) + _, user4 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) + _, user5 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) ctx, _ := testutil.Context(t) group1, err := client.CreateGroup(ctx, user.OrganizationID, codersdk.CreateGroupRequest{ diff --git a/enterprise/coderd/provisionerdaemons_test.go b/enterprise/coderd/provisionerdaemons_test.go index 73a72bc46f889..e04a7a9c4d39d 100644 --- a/enterprise/coderd/provisionerdaemons_test.go +++ b/enterprise/coderd/provisionerdaemons_test.go @@ -58,7 +58,7 @@ func TestProvisionerDaemonServe(t *testing.T) { codersdk.FeatureExternalProvisionerDaemons: 1, }, }) - another := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) + another, _ := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) _, err := another.ServeProvisionerDaemon(context.Background(), user.OrganizationID, []codersdk.ProvisionerType{ codersdk.ProvisionerTypeEcho, }, map[string]string{ @@ -135,7 +135,7 @@ func TestProvisionerDaemonServe(t *testing.T) { require.NoError(t, err) coderdtest.AwaitTemplateVersionJob(t, client, version.ID) template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID) - another := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) + another, _ := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) _ = closer.Close() closer = coderdtest.NewExternalProvisionerDaemon(t, another, user.OrganizationID, map[string]string{ provisionerdserver.TagScope: provisionerdserver.ScopeUser, diff --git a/enterprise/coderd/templates_test.go b/enterprise/coderd/templates_test.go index 4a9935c86935c..e77bafd550540 100644 --- a/enterprise/coderd/templates_test.go +++ b/enterprise/coderd/templates_test.go @@ -34,8 +34,8 @@ func TestTemplateACL(t *testing.T) { }, }) - _, user2 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) - _, user3 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + _, user2 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) + _, user3 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil) template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID) @@ -78,7 +78,7 @@ func TestTemplateACL(t *testing.T) { }) // Create a user to assert they aren't returned in the response. - _, _ = coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + _, _ = coderdtest.CreateAnotherUser(t, client, user.OrganizationID) version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil) template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID) @@ -104,7 +104,7 @@ func TestTemplateACL(t *testing.T) { }, }) - client1, _ := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + client1, _ := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil) template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID) @@ -156,7 +156,7 @@ func TestTemplateACL(t *testing.T) { }, }) - _, user1 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + _, user1 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil) template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID) @@ -196,7 +196,7 @@ func TestTemplateACL(t *testing.T) { }, }) - _, user1 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + _, user1 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil) template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID) @@ -286,7 +286,7 @@ func TestTemplateACL(t *testing.T) { }, }) - client1, user1 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + client1, user1 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil) template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID) @@ -344,8 +344,8 @@ func TestUpdateTemplateACL(t *testing.T) { }, }) - _, user2 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) - _, user3 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + _, user2 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) + _, user3 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil) template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID) @@ -431,8 +431,8 @@ func TestUpdateTemplateACL(t *testing.T) { }, }) - _, user2 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) - _, user3 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + _, user2 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) + _, user3 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil) template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID) req := codersdk.UpdateTemplateACL{ @@ -548,7 +548,7 @@ func TestUpdateTemplateACL(t *testing.T) { }, }) - _, user2 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + _, user2 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil) template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID) req := codersdk.UpdateTemplateACL{ @@ -576,7 +576,7 @@ func TestUpdateTemplateACL(t *testing.T) { }, }) - client2, user2 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + client2, user2 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil) template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID) req := codersdk.UpdateTemplateACL{ @@ -613,8 +613,8 @@ func TestUpdateTemplateACL(t *testing.T) { }, }) - client2, user2 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) - _, user3 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + client2, user2 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) + _, user3 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil) template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID) req := codersdk.UpdateTemplateACL{ @@ -681,7 +681,7 @@ func TestUpdateTemplateACL(t *testing.T) { }, }) - client1, user1 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + client1, user1 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil) template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID) @@ -748,7 +748,7 @@ func TestUpdateTemplateACL(t *testing.T) { }, }) - client1, _ := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + client1, _ := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) version := coderdtest.CreateTemplateVersion(t, client, user.OrganizationID, nil) template := coderdtest.CreateTemplate(t, client, user.OrganizationID, version.ID) @@ -841,7 +841,7 @@ func TestTemplateAccess(t *testing.T) { // - template 3, user_acl read for member // - template 4, group_acl read for groupMember - templateAdmin := coderdtest.CreateAnotherUser(t, ownerClient, owner.OrganizationID, rbac.RoleTemplateAdmin()) + templateAdmin, _ := coderdtest.CreateAnotherUser(t, ownerClient, owner.OrganizationID, rbac.RoleTemplateAdmin()) makeTemplate := func(t *testing.T, client *codersdk.Client, orgID uuid.UUID, acl codersdk.UpdateTemplateACL) codersdk.Template { version := coderdtest.CreateTemplateVersion(t, client, orgID, nil) @@ -862,9 +862,9 @@ func TestTemplateAccess(t *testing.T) { newOrg, err := ownerClient.CreateOrganization(ctx, codersdk.CreateOrganizationRequest{Name: orgName}) require.NoError(t, err, "failed to create org") - adminCli, adminUsr := coderdtest.CreateAnotherUserWithUser(t, ownerClient, newOrg.ID, rbac.RoleOrgAdmin(newOrg.ID)) - groupMemCli, groupMemUsr := coderdtest.CreateAnotherUserWithUser(t, ownerClient, newOrg.ID, rbac.RoleOrgMember(newOrg.ID)) - memberCli, memberUsr := coderdtest.CreateAnotherUserWithUser(t, ownerClient, newOrg.ID, rbac.RoleOrgMember(newOrg.ID)) + adminCli, adminUsr := coderdtest.CreateAnotherUser(t, ownerClient, newOrg.ID, rbac.RoleOrgAdmin(newOrg.ID)) + groupMemCli, groupMemUsr := coderdtest.CreateAnotherUser(t, ownerClient, newOrg.ID, rbac.RoleOrgMember(newOrg.ID)) + memberCli, memberUsr := coderdtest.CreateAnotherUser(t, ownerClient, newOrg.ID, rbac.RoleOrgMember(newOrg.ID)) // Make group group, err := adminCli.CreateGroup(ctx, newOrg.ID, codersdk.CreateGroupRequest{ diff --git a/enterprise/coderd/workspaces_test.go b/enterprise/coderd/workspaces_test.go index ef14d8a6be628..843d23d53eae2 100644 --- a/enterprise/coderd/workspaces_test.go +++ b/enterprise/coderd/workspaces_test.go @@ -51,7 +51,7 @@ func TestCreateWorkspace(t *testing.T) { }) require.NoError(t, err) - client1, user1 := coderdtest.CreateAnotherUserWithUser(t, client, user.OrganizationID) + client1, user1 := coderdtest.CreateAnotherUser(t, client, user.OrganizationID) _, err = client1.Template(ctx, template.ID) require.Error(t, err)