Skip to content

fix: Clean up conn on NewStream error in memDRPC #6182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 13, 2023
Merged

fix: Clean up conn on NewStream error in memDRPC #6182

merged 1 commit into from
Feb 13, 2023

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Feb 13, 2023 •
edited
Loading

If we don't close the connections, we'll leak memory/leave connections open.

@mafredri mafredri self-assigned this Feb 13, 2023
@mafredri mafredri force-pushed the mafredri/fix-provisionersdk-memdrpc-stream-close branch from 2daf091 to e70d1df Compare February 13, 2023 14:27
@mafredri mafredri requested review from coadler and mtojek February 13, 2023 14:36
mtojek
mtojek reviewed Feb 13, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Could you please add a short writeup to the issue description, so that it's clear why is it necessary?

@mafredri
Copy link
Member Author

Hey! Could you please add a short writeup to the issue description, so that it's clear why is it necessary?

Done 👍🏻.

@mtojek
Copy link
Member

mtojek commented Feb 13, 2023 •
edited
Loading

Ok, that's what I expected. Is there any issue that should be linked or did you find it accidentally?

@mafredri
Copy link
Member Author

CI failure, was an easy fix so I didn't open an issue for it.

mtojek
mtojek approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if it helps 👍

@mafredri mafredri merged commit 2157bff into main Feb 13, 2023
@mafredri mafredri deleted the mafredri/fix-provisionersdk-memdrpc-stream-close branch February 13, 2023 15:27
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

@coadler coadler Awaiting requested review from coadler

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mafredri @mtojek