Skip to content

fix: allow disabling all password auth even if owner #6193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 14, 2023
Merged

fix: allow disabling all password auth even if owner #6193

merged 2 commits into from
Feb 14, 2023

Conversation

kylecarbs
Copy link
Member

Removes any and all ability to auth with a password.

@kylecarbs
fix: allow disabling all password auth even if owner
50d0dcb 
Removes any and all ability to auth with a password.
@kylecarbs kylecarbs requested a review from bpmct February 13, 2023 21:30
@kylecarbs kylecarbs self-assigned this Feb 13, 2023
bpmct
bpmct reviewed Feb 13, 2023
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can local accounts still be created?

@kylecarbs
Copy link
Member Author

@bpmct good point... I'll check

@kylecarbs
Copy link
Member Author

@bpmct good check. I removed that ability, and now hide the "Create User" button if password auth is disabled.

@kylecarbs kylecarbs merged commit 51f17b1 into main Feb 14, 2023
@kylecarbs kylecarbs deleted the disablepassauth branch February 14, 2023 14:58
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpmct bpmct bpmct approved these changes

@deansheather deansheather deansheather approved these changes

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kylecarbs @deansheather @bpmct