refactor(site): Highlight immutable parameters and do a few tweaks #6490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
reviewed
Mar 7, 2023
| @@ -70,16 +65,16 @@ export const RichParameterInput: FC<RichParameterInputProps> = ({ | |||
| onChange, | |||
| parameter, | |||
| initialValue, | |||
| ...props | |||
| ...fieldProps | |||
There was a problem hiding this comment.
Why spread this? Isn't it just id?
There was a problem hiding this comment.
Nops, it passes other props. I probably should fix the types to make it clear... Going to make that.
Kira-Pilot
reviewed
Mar 7, 2023
| > | ||
| <FormFields> | ||
| {props.templateSchema | ||
| // We only want to show schema that have redisplay_value equals true |
There was a problem hiding this comment.
I like the addition of a comment here, but I'm still unclear as to why we don't want to show schemas with Ah, I see this isn't scoped to this PR; feel free to ignoreredisplay_value=false
Kira-Pilot
reviewed
Mar 7, 2023
| FormFooter, | ||
| HorizontalForm, | ||
| } from "components/HorizontalForm/HorizontalForm" | ||
| import { makeStyles } from "@material-ui/core/styles" |
There was a problem hiding this comment.
I think it's probably time for this file to be broken apart.
There was a problem hiding this comment.
I think it is! I will do that.
mtojek
approved these changes
Mar 8, 2023
| {props.canCreateForUser && ( | ||
| <FormSection | ||
| title="Workspace owner" | ||
| description=" The user that is going to own this workspace. If you are |
There was a problem hiding this comment.
nit: " The user <- starting spacebar
|
Related to #6076 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Video about the proposed changes:
Screen.Recording.2023-03-03.at.14.23.04.mov
But I decided to move forward with the banner option instead because we have two scenarios:
Aligning the pill with these scenarios and making them look good was kinda hard. I also moved the icon to be left-center aligned with the text to make it easier to align with more generic cases.
Preview:
I added extra stories to make sure we are testing all the cases.