Skip to content

fix!: Disallow access urls without valid scheme #6548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2023
Merged

fix!: Disallow access urls without valid scheme #6548

merged 1 commit into from
Mar 10, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Mar 10, 2023 •
edited
Loading

Existing deployments will need to prepend a scheme if they have not already.

Fixes: #6547

@Emyrk Emyrk requested a review from sreya March 10, 2023 03:24
@Emyrk Emyrk changed the title !fix: Disallow access urls without valid scheme fix!: Disallow access urls without valid scheme Mar 10, 2023
@github-actions github-actions bot added the release/breaking This label is applied to PRs to detect breaking changes as part of the release process label Mar 10, 2023
@Emyrk Emyrk merged commit 11a930e into main Mar 10, 2023
@Emyrk Emyrk deleted the stevenmasley/access_url_scheme branch March 10, 2023 03:37
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sreya sreya sreya approved these changes

Assignees

@Emyrk Emyrk

Labels
release/breaking This label is applied to PRs to detect breaking changes as part of the release process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessurl without scheme:// breaks OIDC redirect
2 participants
@Emyrk @sreya