Skip to content

chore: Ensure all audit types in ResourceTable match APGL #6563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 10, 2023
Merged

chore: Ensure all audit types in ResourceTable match APGL #6563

merged 8 commits into from
Mar 10, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Mar 10, 2023 •
edited
Loading

What this does

We had a regression that a entry in APGL audit.Auditable did not have an entry in the enterprise audit.AuditableResources.

Now audit.AuditableResources and audit.Auditable must match exactly.

Additional Checks

  • All exported fields have an audit action
  • All fields with actions actually exist on the struct.

kylecarbs
kylecarbs approved these changes Mar 10, 2023
View reviewed changes
@Emyrk Emyrk requested a review from kylecarbs March 10, 2023 18:44
kylecarbs
kylecarbs approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sick

@Emyrk Emyrk merged commit 37c859e into main Mar 10, 2023
@Emyrk Emyrk deleted the stevenmasley/audit_types branch March 10, 2023 19:59
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@Emyrk Emyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emyrk @kylecarbs