fix(site): Show job error on updating template variables #6674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
approved these changes
Mar 20, 2023
Kira-Pilot
reviewed
Mar 20, 2023
| <Stack className={classes.errorContainer}> | ||
| <AlertBanner severity="error" text={errors.jobError} /> | ||
| </Stack> | ||
| )} |
There was a problem hiding this comment.
Will all three of these errors show up at once? Curious if we can simplify into one AlertBanner that accepts an error.
There was a problem hiding this comment.
We can for the other two, but not for jobError because it is a string. But I will take a look ok this!
Kira-Pilot
approved these changes
Mar 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduced-size.mov
Fix #6667