feat(coder): Add PATCH /templateversions/:templateversion endpoint #6698
Conversation
| @@ -76,6 +76,10 @@ type TemplateVersionVariable struct { | |||
| Sensitive bool `json:"sensitive"` | |||
| } | |||
|
|
|||
| type PatchTemplateVersionRequest struct { | |||
There was a problem hiding this comment.
I think that I asked this question on slack, but it was missed.
Why in the first place we need to modify the template name? Why using the randomly generated one is bad?
There was a problem hiding this comment.
I think being able to add a custom name for the template version is way easier to identify and find it after IMO.
There was a problem hiding this comment.
Not sure if we need this feature considering the fact that everywhere we keep using the randomly generated. @bpmct what do you think?
|
CI also complains about some unit tests. |
|
As agreed with @BrunoQuaresma, I will take it over to complete. |
|
@BrunoQuaresma I'm done with improvements. Could you please take a look and 👍 or 👎 ? |
|
if it's good by @mtojek it's good by me — i don't have the bandwidth to review this morning |
Before adding tests, I would like to confirm I'm doing the right thing.
related to #6124