Skip to content

feat: add group mapping option for group sync #6705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Mar 21, 2023

Allows mapping group IDs returned from an OIDC provider to a Coder group with a different name.

@coadler coadler self-assigned this Mar 21, 2023
@coadler coadler requested review from Emyrk and bpmct March 21, 2023 19:06
@coadler coadler marked this pull request as ready for review March 21, 2023 19:06
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review the docs, but code LGTM!

Comment on lines +76 to +77
oidcGroupName := "pingpong"
coderGroupName := "bingbong"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

classic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

classic

Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM

@bpmct bpmct merged commit 00860cf into main Mar 21, 2023
@bpmct bpmct deleted the colin/group-mapping branch March 21, 2023 19:25
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants