feat(site): Ask for version name and if it is active when publishing a new version on editor #6756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kira-Pilot
reviewed
Mar 24, 2023
Kira-Pilot
reviewed
Mar 24, 2023
site/src/components/TemplateVersionEditor/PublishTemplateVersionDialog.tsx
Show resolved
Hide resolved
Kira-Pilot
reviewed
Mar 24, 2023
|
This is a really cool feature - great job! Do we need any validation on the version name? I imagine we might get a conflict if we have two of the same name. |
Kira-Pilot
approved these changes
Mar 24, 2023
It is a good question. Let me try and see what happens. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demo:
Screen.Recording.2023-03-23.at.16.07.57.mov
Fix #6169
Close #6124