break loop

coder · mtojek · Mar 30, 2023 · Mar 28, 2023 · Mar 28, 2023 · Mar 28, 2023
commit af908fed1cc7d8078203a3aeead66167133fa83d
diff --git a/coderd/workspacebuilds_test.go b/coderd/workspacebuilds_test.go
@@ -1258,27 +1258,28 @@ func TestWorkspaceBuildDebugMode(t *testing.T) {
 		defer closer.Close()
 
 		var logsProcessed int
+
+	processingLogs:
 		for {
 			select {
 			case <-ctx.Done():
 				require.Fail(t, "timeout occurred while processing logs")
 				return
 			case log, ok := <-logs:
 				if !ok {
-					goto done
+					break processingLogs
 				}
 
 				logsProcessed++
 
 				require.NotEqual(t, "dont-want-it", log.Output, "unexpected log message", "%s log message shouldn't be logged: %s")
 
 				if log.Output == "done" {
-					goto done
+					break processingLogs
 				}
 			}
 		}
 
-	done:
 		require.Len(t, echoResponses.ProvisionApply, logsProcessed)
 	})
 }