Skip to content

fix: allow overridding default string array #6873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 30, 2023
Merged

fix: allow overridding default string array #6873

merged 6 commits into from
Mar 30, 2023

Conversation

ammario
Copy link
Member

@ammario ammario commented Mar 29, 2023 •
edited
Loading

  • Use index instead of name in skip map to reduce dependency on .Name being set

@ammario ammario self-assigned this Mar 29, 2023
@ammario ammario requested a review from kylecarbs March 29, 2023 23:27
@ammario ammario enabled auto-merge (squash) March 29, 2023 23:27
@ammario ammario mentioned this pull request Mar 29, 2023
Closed
@ammario ammario linked an issue Mar 29, 2023 that may be closed by this pull request
Unable to disable P2P connections as it is not possible to set DERP server stun addresses to empty #6791
Closed
@ammario ammario merged commit 58d650c into main Mar 30, 2023
@ammario ammario deleted the cli-defaults branch March 30, 2023 01:09
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2023
@coder coder unlocked this conversation Mar 30, 2023
@ammario ammario mentioned this pull request Mar 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@ammario ammario

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to disable P2P connections as it is not possible to set DERP server stun addresses to empty
2 participants
@ammario @kylecarbs