From 633176e54279062e35914357878f4beadf55ee2e Mon Sep 17 00:00:00 2001 From: Kyle Carberry Date: Thu, 30 Mar 2023 14:40:57 +0000 Subject: [PATCH] chore: use defer instead of `t.Cleanup` for `chdir` This _might_ resolve the races in `TestTemplatePush`. --- cli/templatepush_test.go | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/cli/templatepush_test.go b/cli/templatepush_test.go index 0f7eca58d1cdc..56db595e83b19 100644 --- a/cli/templatepush_test.go +++ b/cli/templatepush_test.go @@ -178,10 +178,7 @@ func TestTemplatePush(t *testing.T) { require.NoError(t, err) os.Chdir(source) - - t.Cleanup(func() { - os.Chdir(oldDir) - }) + defer os.Chdir(oldDir) // Don't pass the name of the template, it should use the // directory of the source.