Skip to content

fix(dbpurge): use dbauthz.AsSystemRestricted #7017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 5, 2023
Merged

fix(dbpurge): use dbauthz.AsSystemRestricted #7017

merged 2 commits into from
Apr 5, 2023

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Apr 5, 2023

Fixes: #7016

@coadler coadler requested a review from kylecarbs April 5, 2023 17:21
@coadler coadler self-assigned this Apr 5, 2023
@coadler coadler requested a review from Emyrk April 5, 2023 17:21
kylecarbs
kylecarbs approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add jitter?

@coadler
Copy link
Contributor Author

coadler commented Apr 5, 2023

So multiple replicas don't all purge at the same time, I guess it doesn't really matter though.

@kylecarbs
Copy link
Member

I think we remove the jitter... it seems more confusing imo

@coadler coadler force-pushed the colin/fix-dbpurge branch from b8f215c to 80ef27f Compare April 5, 2023 17:26
@coadler coadler changed the title fix(dbpurge): use dbauthz.AsSystemRestricted and add jitter fix(dbpurge): use dbauthz.AsSystemRestricted Apr 5, 2023
@coadler coadler enabled auto-merge (squash) April 5, 2023 17:32
@coadler coadler disabled auto-merge April 5, 2023 17:37
@coadler coadler enabled auto-merge (squash) April 5, 2023 17:47
@coadler coadler merged commit 407f80a into main Apr 5, 2023
@coadler coadler deleted the colin/fix-dbpurge branch April 5, 2023 17:48
@github-actions github-actions bot locked and limited conversation to collaborators Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Emyrk Emyrk Emyrk approved these changes

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dbpurge fails due to missing actor in dbauthz
3 participants
@coadler @kylecarbs @Emyrk