From fdade5817a724ace483fa61f264f599c8e9c65a0 Mon Sep 17 00:00:00 2001 From: Kevin Conley Date: Mon, 3 Apr 2023 16:59:43 -0700 Subject: [PATCH] fix: Parse `CODER_GITAUTH_N_NO_REFRESH` env var value instead of key --- cli/server.go | 2 +- cli/server_test.go | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/cli/server.go b/cli/server.go index b6fa7c31b647c..c511087a803eb 100644 --- a/cli/server.go +++ b/cli/server.go @@ -142,7 +142,7 @@ func ReadGitAuthProvidersFromEnv(environ []string) ([]codersdk.GitAuthConfig, er case "REGEX": provider.Regex = v.Value case "NO_REFRESH": - b, err := strconv.ParseBool(key) + b, err := strconv.ParseBool(v.Value) if err != nil { return nil, xerrors.Errorf("parse bool: %s", v.Value) } diff --git a/cli/server_test.go b/cli/server_test.go index b4f1901a993fa..ee591d7a3eafe 100644 --- a/cli/server_test.go +++ b/cli/server_test.go @@ -80,6 +80,7 @@ func TestReadGitAuthProvidersFromEnv(t *testing.T) { "CODER_GITAUTH_1_TOKEN_URL=google.com", "CODER_GITAUTH_1_VALIDATE_URL=bing.com", "CODER_GITAUTH_1_SCOPES=repo:read repo:write", + "CODER_GITAUTH_1_NO_REFRESH=true", }) require.NoError(t, err) require.Len(t, providers, 2) @@ -95,6 +96,7 @@ func TestReadGitAuthProvidersFromEnv(t *testing.T) { assert.Equal(t, "google.com", providers[1].TokenURL) assert.Equal(t, "bing.com", providers[1].ValidateURL) assert.Equal(t, []string{"repo:read", "repo:write"}, providers[1].Scopes) + assert.Equal(t, true, providers[1].NoRefresh) }) }