From 782ef583f0aeb06c3c664e0fef0915067e54010e Mon Sep 17 00:00:00 2001 From: Colin Adler Date: Wed, 12 Apr 2023 19:22:46 -0500 Subject: [PATCH] fix(healthcheck): prevent infinite loop if DERP message exchange fails --- coderd/healthcheck/derp.go | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/coderd/healthcheck/derp.go b/coderd/healthcheck/derp.go index e4cb206f3ead0..c3b3f1991991b 100644 --- a/coderd/healthcheck/derp.go +++ b/coderd/healthcheck/derp.go @@ -2,9 +2,7 @@ package healthcheck import ( "context" - "errors" "fmt" - "io" "net" "net/netip" "net/url" @@ -390,9 +388,7 @@ func (*DERPNodeReport) recvData(client *derphttp.Client) (derp.ReceivedPacket, e for { msg, err := client.Recv() if err != nil { - if errors.Is(err, io.EOF) { - return derp.ReceivedPacket{}, nil - } + return derp.ReceivedPacket{}, err } switch msg := msg.(type) {