Skip to content

fix(cli): select default option value #7152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2023
Merged

fix(cli): select default option value #7152

merged 1 commit into from
Apr 17, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Apr 17, 2023

Fixes: #7148

This PR improves the RichSelect logic to correctly identify the default option.

@mtojek mtojek self-assigned this Apr 17, 2023
@mtojek mtojek changed the title fix: select default option value fix(cli): select default option value Apr 17, 2023
@mtojek mtojek marked this pull request as ready for review April 17, 2023 10:53
@mtojek mtojek requested review from mafredri and johnstcn April 17, 2023 10:53
@mtojek mtojek merged commit c39c0dc into coder:main Apr 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 17, 2023
johnstcn
johnstcn reviewed Apr 17, 2023
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn left review comments

@mafredri mafredri mafredri approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

selecting the default value of a coder_parameter returns build error
3 participants
@mtojek @mafredri @johnstcn