From 2480f1cd695cb9f6519d0c7f33c4df5d78ff80c5 Mon Sep 17 00:00:00 2001 From: Colin Adler Date: Mon, 17 Apr 2023 14:39:24 -0500 Subject: [PATCH] fix(healthcheck): remove `t.Parallel()` from healthcheck tests These seem to sometimes fail under load, so don't run them in parallel with other tests. --- coderd/healthcheck/derp_test.go | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/coderd/healthcheck/derp_test.go b/coderd/healthcheck/derp_test.go index fdc313e72bd28..83579ee36b683 100644 --- a/coderd/healthcheck/derp_test.go +++ b/coderd/healthcheck/derp_test.go @@ -21,8 +21,11 @@ import ( "github.com/coder/coder/tailnet" ) +//nolint:tparallel func TestDERP(t *testing.T) { - t.Parallel() + if testing.Short() { + t.Skip("skipping healthcheck test in short mode, they reach out over the network.") + } t.Run("OK", func(t *testing.T) { t.Parallel()