fix: macOS pty race with dropped output #7278
Conversation
Signed-off-by: Spike Curtis <spike@coder.com>
| if err := opty.tty.Close(); err != nil { | ||
| _ = cmd.Process.Kill() | ||
| return nil, nil, xerrors.Errorf("close tty: %w", err) | ||
| if runtime.GOOS == "linux" { |
There was a problem hiding this comment.
I wonder if, down the line, this might give us a bad time trying to support other OSs (e.g. BSD variants).
I found a SO post that confirms Darwin like behavior on FreeBSD (8.2) as well, but apparently the behavior may be closer to Linux in 10.0 which could mean we may block on output copy.
https://stackoverflow.com/a/25123701
A comment mentions checking tcgetattr on master to decide if we keep both ends open but no idea hire reliable that is: https://stackoverflow.com/questions/23458160/final-output-on-slave-pty-is-lost-if-it-was-not-closed-in-parent-why/25123701#comment36273878_23458160
There was a problem hiding this comment.
It definitely might!
But, the unit test we have should fail if the BSD version we intend to support acts like Linux and doesn't get the close, so I guess we'll just cross that bridge if we come to it.
No description provided.