Skip to content

fix: Reconnecting PTY waits for command output or EOF #7279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 26, 2023
Merged

fix: Reconnecting PTY waits for command output or EOF #7279

merged 1 commit into from
Apr 26, 2023

Conversation

spikecurtis
Copy link
Contributor

Missed this PTY handling in ReconnectingPTY --- simplifying a la our SSH handling.

This should fix (some of) the intermittent failures we're seeing on main.

@spikecurtis
Reconnecting PTY waits for command output or EOF
77da685 
Signed-off-by: Spike Curtis <spike@coder.com>
@spikecurtis spikecurtis requested a review from mafredri April 25, 2023 11:45
@spikecurtis spikecurtis merged commit 29cbc54 into main Apr 26, 2023
@spikecurtis spikecurtis deleted the spike/reconnecting-pty-fixes branch April 26, 2023 05:02
@github-actions github-actions bot locked and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

Assignees

@spikecurtis spikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spikecurtis @mafredri