feat(cli): support non-active template version pushes #7488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that we can push template updates for testing without impacting normal users of the template.
ammario
requested changes
May 12, 2023
cli/templatepush.go
Outdated
| @@ -233,6 +236,12 @@ func (r *RootCmd) templatePush() *clibase.Cmd { | |||
| Description: "Always prompt all parameters. Does not pull parameter values from active template version.", | |||
| Value: clibase.BoolOf(&alwaysPrompt), | |||
| }, | |||
| { | |||
| Flag: "make-active", | |||
There was a problem hiding this comment.
Let's make this activate, and the variables too.
There was a problem hiding this comment.
When I run make, I get errors that seem unrelated to this change:
Errors
# github.com/cenkalti/backoff/v4
../../go/pkg/mod/github.com/cenkalti/backoff/v4@v4.2.0/retry.go:10:26: syntax error: unexpected any, expecting ]
../../go/pkg/mod/github.com/cenkalti/backoff/v4@v4.2.0/retry.go:10:38: method has no receiver
../../go/pkg/mod/github.com/cenkalti/backoff/v4@v4.2.0/retry.go:16:53: syntax error: unexpected [ after top level declaration
../../go/pkg/mod/github.com/cenkalti/backoff/v4@v4.2.0/retry.go:17:16: method has no receiver
../../go/pkg/mod/github.com/cenkalti/backoff/v4@v4.2.0/retry.go:17:16: syntax error: unexpected (, expecting name or (
../../go/pkg/mod/github.com/cenkalti/backoff/v4@v4.2.0/retry.go:42:19: syntax error: unexpected [, expecting (
../../go/pkg/mod/github.com/cenkalti/backoff/v4@v4.2.0/retry.go:53:25: syntax error: unexpected [, expecting (
../../go/pkg/mod/github.com/cenkalti/backoff/v4@v4.2.0/retry.go:66:33: syntax error: unexpected [, expecting (
../../go/pkg/mod/github.com/cenkalti/backoff/v4@v4.2.0/retry.go:70:19: syntax error: unexpected [, expecting (
../../go/pkg/mod/github.com/cenkalti/backoff/v4@v4.2.0/retry.go:76:2: syntax error: non-declaration statement outside function body
../../go/pkg/mod/github.com/cenkalti/backoff/v4@v4.2.0/retry.go:76:2: too many errors
note: module requires Go 1.18
# github.com/coder/coder/cryptorand
cryptorand/slices.go:9:6: missing function body
cryptorand/slices.go:9:13: syntax error: unexpected [, expecting (
note: module requires Go 1.20
Makefile:473: recipe for target 'coderd/database/dump.sql' failed
make: *** [coderd/database/dump.sql] Error 2
|
@goodspark it looks like you're on a pre-generics version of the Go toolchain. Try rerunning the commands with go 1.20. |
ammario
reviewed
May 13, 2023
|
Yeah, sure. My env has some old version of Golang and since I rarely use it at work, I haven't been bothered enough to download the 1.20. |
matifali
reviewed
May 17, 2023
b14f30c to
ebdcc6c
Compare
ammario
approved these changes
Jun 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we can push template updates for testing without impacting normal users of the template.