Skip to content

fix(site): Fix focus state on buttons #7526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2023
Merged

fix(site): Fix focus state on buttons #7526

merged 1 commit into from
May 15, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Fix #4262

@BrunoQuaresma BrunoQuaresma requested review from matifali and a team May 15, 2023 12:14
@BrunoQuaresma BrunoQuaresma self-assigned this May 15, 2023
@BrunoQuaresma BrunoQuaresma requested review from rodrimaia and removed request for a team May 15, 2023 12:14
@BrunoQuaresma BrunoQuaresma marked this pull request as ready for review May 15, 2023 12:14
@BrunoQuaresma
Copy link
Collaborator Author

Not sure why yarn.lock changed and how it gets merged into the main since the CI should throw an error but, I will let the changes in this PR since it is a "fix".

@matifali
Copy link
Member

I am not sure about the yarn.lock and if it has any effect. I will wait for @rodrimaia to review the changes.
And Thanks @BrunoQuaresma for a quick follow-up and fix.

@matifali matifali removed their request for review May 15, 2023 12:43
@BrunoQuaresma BrunoQuaresma merged commit d9fc94f into main May 15, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-tab-index branch May 15, 2023 17:43
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rodrimaia rodrimaia rodrimaia approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(UI): Tab selection does not work on delete workspace dialogue.
3 participants
@BrunoQuaresma @matifali @rodrimaia