Skip to content

feat: add 'impending deletion' badges to workspaces page #7530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 15, 2023
Merged

feat: add 'impending deletion' badges to workspaces page #7530

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0ba53bd
update deleting logic
Kira-Pilot May 11, 2023
1255b07
added status badge on workspaces page
Kira-Pilot May 12, 2023
3618c5d
licensing and feature flagging
Kira-Pilot May 12, 2023
d6adbd9
preset filter for failed workspaces
Kira-Pilot May 12, 2023
e00ed2a
remove comment
Kira-Pilot May 15, 2023
2dfbb50
PR feedback
Kira-Pilot May 15, 2023
3c72d11
Revert "PR feedback"
Kira-Pilot May 15, 2023
fc8e51c
PR feedback 2
Kira-Pilot May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
preset filter for failed workspaces
  • Loading branch information
@Kira-Pilot
Kira-Pilot committed May 12, 2023
commit d6adbd9fe417625cf2cce7cc5ef5645ebd56e13d
4 changes: 4 additions & 0 deletions site/src/pages/WorkspacesPage/WorkspacesPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ export const WorkspacesPageView: FC<
query: workspaceFilterQuery.running,
name: Language.runningWorkspacesButton,
},
{
query: workspaceFilterQuery.failed,
name: "Failed workspaces",
},
]

return (
Expand Down
1 change: 1 addition & 0 deletions site/src/utils/filters.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ describe("queryToFilter", () => {
["me/dev", { q: "me/dev" }],
["me/", { q: "me/" }],
[" key:val owner:me ", { q: "key:val owner:me" }],
["status:failed", { q: "status:failed" }],
])(`query=%p, filter=%p`, (query, filter) => {
expect(queryToFilter(query)).toEqual(filter)
})
Expand Down
1 change: 1 addition & 0 deletions site/src/utils/filters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ export const workspaceFilterQuery = {
me: "owner:me",
all: "",
running: "status:running",
failed: "status:failed",
}

export const userFilterQuery = {
Expand Down