From 2c40b15b99d70c0993774f4075f30b5f81cb2d72 Mon Sep 17 00:00:00 2001 From: Marcin Tojek Date: Mon, 15 May 2023 16:29:00 +0200 Subject: [PATCH 1/2] fix: set default sshMaxTimeout to 60s --- cli/agent.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/agent.go b/cli/agent.go index da39f1caa22b9..04626d2d4e42a 100644 --- a/cli/agent.go +++ b/cli/agent.go @@ -263,7 +263,7 @@ func (r *RootCmd) workspaceAgent() *clibase.Cmd { }, { Flag: "ssh-max-timeout", - Default: "0", + Default: "60s", Env: "CODER_AGENT_SSH_MAX_TIMEOUT", Description: "Specify the max timeout for a SSH connection.", Value: clibase.DurationOf(&sshMaxTimeout), From df5ad61a6d75502b934a0eb204fd8e34b2f4ffe2 Mon Sep 17 00:00:00 2001 From: Marcin Tojek Date: Mon, 15 May 2023 16:40:44 +0200 Subject: [PATCH 2/2] fix --- cli/testdata/coder_agent_--help.golden | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/testdata/coder_agent_--help.golden b/cli/testdata/coder_agent_--help.golden index 5b9e6f394076e..399a661950a2c 100644 --- a/cli/testdata/coder_agent_--help.golden +++ b/cli/testdata/coder_agent_--help.golden @@ -21,7 +21,7 @@ Starts the Coder workspace agent. --prometheus-address string, $CODER_AGENT_PROMETHEUS_ADDRESS (default: 127.0.0.1:2112) The bind address to serve Prometheus metrics. - --ssh-max-timeout duration, $CODER_AGENT_SSH_MAX_TIMEOUT (default: 0) + --ssh-max-timeout duration, $CODER_AGENT_SSH_MAX_TIMEOUT (default: 60s) Specify the max timeout for a SSH connection. --tailnet-listen-port int, $CODER_AGENT_TAILNET_LISTEN_PORT (default: 0)