Skip to content

chore: add CLI invokation telemetry #7589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 24, 2023
Merged

chore: add CLI invokation telemetry #7589

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
76912df
Send command invocation info in CLI
ammario May 15, 2023
0b2d56b
Get to middleware
ammario May 16, 2023
c6f7504
Add mw
ammario May 16, 2023
6721173
Record InvokedAt
ammario May 16, 2023
0649152
Improve logging
ammario May 16, 2023
9d9c2e5
Merge remote-tracking branch 'origin/main' into cli-telemetry
ammario May 17, 2023
586130d
Better comments
ammario May 17, 2023
b07281b
comments
ammario May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Record InvokedAt
  • Loading branch information
@ammario
ammario committed May 16, 2023
commit 672117307cb3a34b0cde1e8418dd08dee5d0b5e1
5 changes: 3 additions & 2 deletions cli/root.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,8 +440,9 @@ func telemetryInvocation(i *clibase.Invocation) telemetry.CLIInvocation {
})
}
return telemetry.CLIInvocation{
Command: i.Command.FullName(),
Options: topts,
Command: i.Command.FullName(),
Options: topts,
InvokedAt: time.Now(),
}
}

Expand Down
2 changes: 2 additions & 0 deletions coderd/telemetry/telemetry.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,6 +883,8 @@ type CLIOption struct {
type CLIInvocation struct {
Command string `json:"command"`
Options []CLIOption `json:"options"`
// InvokedAt is provided for deduplication purposes.
InvokedAt time.Time `json:"invoked_at"`
}

type noopReporter struct{}
Expand Down