Skip to content

fix: disable TCP SACK #7624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2023
Merged

fix: disable TCP SACK #7624

merged 2 commits into from
May 22, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented May 22, 2023

Related: #7388

This PR updates dependency on coder/tailscale to include coder/tailscale#26. It also reverts the PR-fix for gvisor.

@mtojek mtojek requested review from mafredri and kylecarbs May 22, 2023 12:10
@mtojek mtojek self-assigned this May 22, 2023
@mtojek mtojek marked this pull request as ready for review May 22, 2023 12:10
@mafredri
Copy link
Member

I think we're missing #7418 to be able to merge this. Either that, or we need to roll back main in our tailscale repo, or work on a separate branch that is not yet upgraded. 🤔

@mtojek
Copy link
Member Author

mtojek commented May 22, 2023

Let me prepare a branch and cherry-pick it quickly.

@mtojek mtojek force-pushed the 7500-disable-sack branch from 71b29bc to bec8c40 Compare May 22, 2023 12:54
@mtojek mtojek enabled auto-merge (squash) May 22, 2023 13:07
@mtojek mtojek merged commit f9a97c2 into coder:main May 22, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants