Skip to content

feat: order workspaces by running first #7656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 25, 2023
Merged

feat: order workspaces by running first #7656

merged 6 commits into from
May 25, 2023

Conversation

rodrimaia
Copy link
Contributor

@rodrimaia rodrimaia commented May 23, 2023 •
edited by mtojek
Loading

Fixes: #7492

This PR modifies sorting logic of workspaces to ensure the following order:

  1. Sort by status - "running" first.
  2. Sort by username.
  3. Sort by workspace name.

@mtojek mtojek changed the title draft: order workspaces by running first feat: order workspaces by running first May 25, 2023
@mtojek mtojek requested a review from johnstcn May 25, 2023 16:26
@mtojek mtojek marked this pull request as ready for review May 25, 2023 16:26
@mtojek
Copy link
Member

mtojek commented May 25, 2023

@rodrimaia Feel free to review or push changes!

@rodrimaia rodrimaia merged commit d9299ca into main May 25, 2023
@rodrimaia rodrimaia deleted the order_by_workspaces branch May 25, 2023 16:35
@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek left review comments

@johnstcn johnstcn johnstcn approved these changes

Assignees

@rodrimaia rodrimaia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

workspace list is constantly refreshing with multiple active users/workspaces
3 participants
@rodrimaia @mtojek @johnstcn