fix: wildcard dns docs #7709
Merged
fix: wildcard dns docs #7709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spike Curtis <spike@coder.com>
matifali
reviewed
May 30, 2023
docs/admin/configure.md
Outdated
| 1. use a single certificate/key for the root and wildcard domains. | ||
| 2. configure both root and wildcard domain certificates/keys via | ||
| [`coder.tls.secretNames`](https://github.com/coder/coder/blob/main/helm/values.yaml) in the Helm Chart, or | ||
| [`--tls-key-file`](../cli/server#--tls-cert-file) and [`--tls-key-file`](../cli/server#--tls-key-file) command |
There was a problem hiding this comment.
Suggested change
| [`--tls-key-file`](../cli/server#--tls-cert-file) and [`--tls-key-file`](../cli/server#--tls-key-file) command | |
| [`--tls-cert-file`](../cli/server#--tls-cert-file) and [`--tls-key-file`](../cli/server#--tls-key-file) command |
There was a problem hiding this comment.
@spikecurtis I guess this was a typo.
docs/admin/configure.md
Outdated
Comment on lines
43
to
44
| 1. use a single certificate/key for the root and wildcard domains. | ||
| 2. configure both root and wildcard domain certificates/keys via |
There was a problem hiding this comment.
Suggested change
| 1. use a single certificate/key for the root and wildcard domains. | |
| 2. configure both root and wildcard domain certificates/keys via | |
| 1. Use a single certificate and key for both the root and wildcard domains. | |
| 2. Configure multiple certificates and keys via |
docs/admin/configure.md
Outdated
| 1. use a single certificate/key for the root and wildcard domains. | ||
| 2. configure both root and wildcard domain certificates/keys via | ||
| [`coder.tls.secretNames`](https://github.com/coder/coder/blob/main/helm/values.yaml) in the Helm Chart, or | ||
| [`--tls-key-file`](../cli/server#--tls-cert-file) and [`--tls-key-file`](../cli/server#--tls-key-file) command |
There was a problem hiding this comment.
you should specify that this should be specified as a comma separated list or the flag can be specified multiple times
deansheather
approved these changes
May 30, 2023
ammario
pushed a commit
that referenced
this pull request
Jun 1, 2023
* Fix wildcard dns docs Signed-off-by: Spike Curtis <spike@coder.com> * Clarify Signed-off-by: Spike Curtis <spike@coder.com> --------- Signed-off-by: Spike Curtis <spike@coder.com>
ammario
pushed a commit
to goodspark/coder
that referenced
this pull request
Jun 1, 2023
* Fix wildcard dns docs Signed-off-by: Spike Curtis <spike@coder.com> * Clarify Signed-off-by: Spike Curtis <spike@coder.com> --------- Signed-off-by: Spike Curtis <spike@coder.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.