Skip to content

docs: make template git auth example in sync with git auth setup example #7784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

sharkymark
Copy link
Contributor

I witnessed a prospect's confusion in getting OAuth-based git authentication working in a template, because the docs example didn't match the deployment Git OAuth setup example.

In particular, the id in the coder_git_auth data source was github and not primary-github in the deployment configuration example.

Updating the docs to prevent future customer support calls.

Copy link
Member

@ericpaulsen ericpaulsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sharkymark sharkymark enabled auto-merge (squash) June 1, 2023 19:34
@sharkymark sharkymark merged commit 49ae490 into main Jun 1, 2023
@sharkymark sharkymark deleted the docs-git-parity branch June 1, 2023 19:34
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants