Skip to content

feat(site): add new filter to the users page #7818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 6, 2023
Merged

Conversation

BrunoQuaresma
Copy link
Collaborator

Screen Shot 2023-06-02 at 15 11 45

@BrunoQuaresma BrunoQuaresma requested review from Kira-Pilot and bpmct June 2, 2023 18:12
@BrunoQuaresma BrunoQuaresma self-assigned this Jun 2, 2023
@matifali
Copy link
Member

matifali commented Jun 2, 2023

Thoughts on adding a 2nd filter for roles? With multi-select?

@Kira-Pilot
Copy link
Member

Kira-Pilot commented Jun 5, 2023

I love the filter hook API. Down the road, it would be cool to see a return of filter presets, or a way to link to filter documentation. I worry about discoverability of some filters, especially in /workspaces where we're adding filters to show workspaces that are impending deletion, which is not a formal workspace status. The original plan was to add some presets but I'm not sure to best integrate those presets with this improved design.

@BrunoQuaresma
Copy link
Collaborator Author

@matifali I think this is a good feature but, I think we never had users asking for this before - since we don't have a preset filter for it. So I would just wait a bit since I would have to add a bit more code to handle it.

@cdr-bot cdr-bot bot added the community Pull Requests and issues created by the community. label Jun 6, 2023
@BrunoQuaresma BrunoQuaresma merged commit baa9922 into main Jun 6, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/users-filter branch June 6, 2023 12:59
@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2023
@ammario ammario removed the community Pull Requests and issues created by the community. label Jun 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants