Skip to content

revert(provisionersdk): remove support for .tf.json files #7829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 2, 2023

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Jun 2, 2023

I noticed while looking through the code that rich parameters has hardcoded support only for .tf files. This means rich parameters won't work with non-hcl templates:

if !strings.HasSuffix(entry.Name(), ".tf") {

This will need to be resolved before allowing .tf.json files again.

@coadler coadler requested a review from ammario June 2, 2023 22:50
@coadler coadler self-assigned this Jun 2, 2023
@coadler coadler enabled auto-merge (squash) June 2, 2023 22:59
@coadler coadler merged commit 14a63d7 into main Jun 2, 2023
@coadler coadler deleted the colin/revert-tfjson branch June 2, 2023 23:13
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants