Skip to content

chore: add warning log if misconfigured groups oidc #7874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 8, 2023
Merged

chore: add warning log if misconfigured groups oidc #7874

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e553d87
chore: add warning log if misconfigured groups oidc
Emyrk Jun 6, 2023
53c51e6
Push it to debug log
Emyrk Jun 6, 2023
2d3b335
Add docs
Emyrk Jun 6, 2023
e81a81b
Update cli help msg
Emyrk Jun 6, 2023
404370e
Make gen
Emyrk Jun 6, 2023
1e45b1f
Update golden
Emyrk Jun 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update golden
  • Loading branch information
@Emyrk
Emyrk committed Jun 7, 2023
commit 1e45b1fe044a56d056bf1cbd046ca0873f9449a2
4 changes: 2 additions & 2 deletions cli/testdata/coder_server_--help.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,8 +296,8 @@ can safely ignore these settings.
OIDC claim field to use as the email.

--oidc-group-field string, $CODER_OIDC_GROUP_FIELD
Change the OIDC default 'groups' claim field. By default, will be
'groups' if present in the oidc scopes argument.
This field must be set if using the group sync feature and the scope
name is not 'groups'. Set to the claim to be used for groups.

--oidc-group-mapping struct[map[string]string], $CODER_OIDC_GROUP_MAPPING (default: {})
A map of OIDC group IDs and the group in Coder it should map to. This
Expand Down
4 changes: 2 additions & 2 deletions cli/testdata/server-config.yaml.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,8 +238,8 @@ oidc:
# Ignore the userinfo endpoint and only use the ID token for user information.
# (default: false, type: bool)
ignoreUserInfo: false
# Change the OIDC default 'groups' claim field. By default, will be 'groups' if
# present in the oidc scopes argument.
# This field must be set if using the group sync feature and the scope name is not
# 'groups'. Set to the claim to be used for groups.
# (default: <unset>, type: string)
groupField: ""
# A map of OIDC group IDs and the group in Coder it should map to. This is useful
Expand Down