chore: fix miscellaneous issues in scaletest scripts #8006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
johnstcn
commented
Jun 13, 2023
- scaletest.go: actually wait for prometheus metrics regardless of tracing
- coder_workspacetraffic.sh: allow specifying traffic rate
- scaletest.sh: plumb through scaletest traffic options
mtojek
approved these changes
Jun 14, 2023
| } | ||
| // Wait for prometheus metrics to be scraped |
There was a problem hiding this comment.
nit: I'm wondering if there could be an active loop implemented instead to make sure that metrics have been scraped. Nothing is wrong with this submission though!
There was a problem hiding this comment.
I considered that as well but didn't think it worth the additional complexity.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.