Skip to content

feat: add login type 'none' to prevent password login #8009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 14, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jun 13, 2023

Fixes #7657

Users with this login type must use tokens to authenticate.
Tokens must come from some other source, not a /login with password
authentication

Cli usage & Output

$ coder users create --disable-login                                                                                                                   48s 12:27:17 PM
> Username: noauth2
> Email: noauth2@coder.com
A new user has been created!
Share the instructions below to get them started.
—————————————————————————————————————————————————
Download the Coder command line for your operating system:
https://github.com/coder/coder/releases

Run  coder login http://localhost:3000  to authenticate.

Your email is:  noauth2@coder.com 
Login has been disabled for this user. Contact your administrator to authenticate.

Create a workspace   coder create !

Future Work

This is the initial work to disable password authentication on a user by user basis. To polish this feature, I believe we need some extra features.

Emyrk added 2 commits June 13, 2023 11:27
Users with this login type must use tokens to authenticate.
Tokens must come from some other source, not a /login with password
authentication
@Emyrk Emyrk changed the title eat: add login type 'none' to prevent login eat: add login type 'none' to prevent password login Jun 13, 2023
@Emyrk Emyrk marked this pull request as ready for review June 13, 2023 18:03
@Emyrk Emyrk changed the title eat: add login type 'none' to prevent password login feat: add login type 'none' to prevent password login Jun 13, 2023
@Emyrk Emyrk requested a review from deansheather June 13, 2023 19:35
Emyrk and others added 2 commits June 13, 2023 15:01
Co-authored-by: Dean Sheather <dean@deansheather.com>
@Emyrk Emyrk merged commit 6c4c3d6 into main Jun 14, 2023
@Emyrk Emyrk deleted the stevenmasley/no_password branch June 14, 2023 17:48
@github-actions github-actions bot locked and limited conversation to collaborators Jun 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--disable-password-auth is useless when using Coder in a headless fashion
2 participants