fix(site): resize terminal when dismissing warning #8028
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoQuaresma
commented
Jun 14, 2023
| "pattern": "docs/contributing/frontend.md" | ||
| } | ||
| ] | ||
| "prettier.prettierPath": "./node_modules/prettier" |
There was a problem hiding this comment.
Not related to the PR but it should ensure we are using the right prettier binary
Kira-Pilot
reviewed
Jun 14, 2023
| } | ||
| return undefined | ||
| }) | ||
| } |
There was a problem hiding this comment.
Maybe? I just moved the existent code.
Kira-Pilot
approved these changes
Jun 14, 2023
|
@BrunoQuaresma I noticed the issue that (I think?) this was supposed to address is still present (from dev.coder.com, today): Before dismiss: 
After (text should go to the bottom but it's permanently "in the air" until I resize the browser window): 
|
|
Strange.... can you please re-open the issue and assign it to me? |
|
@BrunoQuaresma I couldn't find one, so I opened a new one #8175 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.