chore: merge database gen scripts #8073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammario
approved these changes
Jun 19, 2023
| // change. If locks are deprecated, they should be kept to avoid reusing the | ||
| // same ID. | ||
| const ( | ||
| LockIDDeploymentSetup = iota + 1 |
There was a problem hiding this comment.
This is just how it was... seemed risky to change as part of this.
There was a problem hiding this comment.
I don't know what the original reason was, but a typical reason is to avoid mixing it with the zero value. FWIW.
564895a to
f5d8433
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.