diff --git a/site/src/components/Filter/filter.tsx b/site/src/components/Filter/filter.tsx index 4712940565e2d..010bc05012223 100644 --- a/site/src/components/Filter/filter.tsx +++ b/site/src/components/Filter/filter.tsx @@ -204,6 +204,9 @@ export const Filter = ({ "& .MuiInputAdornment-root": { marginLeft: 0, }, + "&.Mui-error": { + zIndex: 3, + }, }, startAdornment: ( diff --git a/site/src/pages/AuditPage/AuditPage.tsx b/site/src/pages/AuditPage/AuditPage.tsx index b5932443f8792..d4c5fc4e9c883 100644 --- a/site/src/pages/AuditPage/AuditPage.tsx +++ b/site/src/pages/AuditPage/AuditPage.tsx @@ -77,6 +77,7 @@ const AuditPage: FC = () => { dashboard.experiments.includes("workspace_filter") ? { filter, + error, menus: { user: userMenu, action: actionMenu, diff --git a/site/src/pages/AuditPage/AuditPageView.tsx b/site/src/pages/AuditPage/AuditPageView.tsx index 559faefb8a0ad..05476646a709f 100644 --- a/site/src/pages/AuditPage/AuditPageView.tsx +++ b/site/src/pages/AuditPage/AuditPageView.tsx @@ -74,8 +74,8 @@ export const AuditPageView: FC = ({ }) => { const { t } = useTranslation("auditLog") - const isLoading = auditLogs === undefined || count === undefined - const isEmpty = !isLoading && auditLogs.length === 0 + const isLoading = (auditLogs === undefined || count === undefined) && !error + const isEmpty = !isLoading && auditLogs?.length === 0 return ( @@ -104,8 +104,8 @@ export const AuditPageView: FC = ({ diff --git a/site/src/pages/UsersPage/UsersPage.tsx b/site/src/pages/UsersPage/UsersPage.tsx index 7760e0a262219..07ce4f949d6aa 100644 --- a/site/src/pages/UsersPage/UsersPage.tsx +++ b/site/src/pages/UsersPage/UsersPage.tsx @@ -159,6 +159,7 @@ export const UsersPage: FC<{ children?: ReactNode }> = () => { dashboard.experiments.includes("workspace_filter") ? { filter: useFilterResult, + error: getUsersError, menus: { status: statusMenu, }, diff --git a/site/src/pages/UsersPage/UsersPageView.stories.tsx b/site/src/pages/UsersPage/UsersPageView.stories.tsx index ee1de11067bdc..cf347a3c717ac 100644 --- a/site/src/pages/UsersPage/UsersPageView.stories.tsx +++ b/site/src/pages/UsersPage/UsersPageView.stories.tsx @@ -17,6 +17,7 @@ const meta: Meta = { isNonInitialPage: false, users: [MockUser, MockUser2], roles: MockAssignableSiteRoles, + count: 2, canEditUsers: true, filterProps: { onFilter: action("onFilter"), @@ -41,12 +42,13 @@ export const Member = { } export const Empty = { - args: { users: [] }, + args: { users: [], count: 0 }, } export const EmptyPage = { args: { users: [], + count: 0, isNonInitialPage: true, }, } diff --git a/site/src/pages/UsersPage/UsersPageView.tsx b/site/src/pages/UsersPage/UsersPageView.tsx index 078c46585bf5e..d47e44228a158 100644 --- a/site/src/pages/UsersPage/UsersPageView.tsx +++ b/site/src/pages/UsersPage/UsersPageView.tsx @@ -77,8 +77,8 @@ export const UsersPageView: FC> = ({ diff --git a/site/src/pages/WorkspacesPage/WorkspacesPageView.tsx b/site/src/pages/WorkspacesPage/WorkspacesPageView.tsx index 297f0c40f9a0b..72e8ea83113cc 100644 --- a/site/src/pages/WorkspacesPage/WorkspacesPageView.tsx +++ b/site/src/pages/WorkspacesPage/WorkspacesPageView.tsx @@ -146,9 +146,9 @@ export const WorkspacesPageView: FC< diff --git a/site/src/xServices/users/usersXService.ts b/site/src/xServices/users/usersXService.ts index 59dd1a5bf1be9..37d67b36b1cad 100644 --- a/site/src/xServices/users/usersXService.ts +++ b/site/src/xServices/users/usersXService.ts @@ -166,11 +166,7 @@ export const usersMachine = onError: [ { target: "idle", - actions: [ - "clearUsers", - "assignGetUsersError", - "displayGetUsersErrorMessage", - ], + actions: ["clearUsers", "assignGetUsersError"], }, ], }, @@ -487,13 +483,6 @@ export const usersMachine = clearUpdateUserRolesError: assign({ updateUserRolesError: (_) => undefined, }), - displayGetUsersErrorMessage: (context) => { - const message = getErrorMessage( - context.getUsersError, - Language.getUsersError, - ) - displayError(message) - }, displaySuspendSuccess: () => { displaySuccess(Language.suspendUserSuccess) },