feat: add flag for Windows to create unix compatible filepaths #8164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
approved these changes
Jun 22, 2023
|
|
||
| package cli | ||
|
|
||
| var hideForceUnixSlashes = true |
There was a problem hiding this comment.
I don't know if it's considered good practice or not, but there's a trick you can use to avoid the build flag:
var hideForceUnixSlashes = func() bool { return runtime.GOOS == "windows" }()I'll leave it up to you whether or not to use it (two less files might be nice). 😄
There was a problem hiding this comment.
I was following our other pattern. I was unsure if a build tag or that was the move
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7639